Skip to content

Allow latest rubocop #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pboling wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow latest rubocop #145

pboling wants to merge 3 commits into from

Conversation

@pboling
Copy link

@pboling pboling commented Apr 24, 2020 •
edited
Loading

Fixes #144

  • allow latest Rubocop
  • update readme to explain to users that they shoudl lock Rubocop (everyone should already be dooing this, but good to point out for new users).
  • Why did the coverage drop so much? I ran bundle exec rspec, and has three passing examples.

@apiology apiology self-requested a review September 9, 2020 13:07
apiology
apiology requested changes Sep 26, 2020
View reviewed changes
Copy link
Owner

@apiology apiology left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apiology apiology apiology requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rubocop is under heavy development, but dependency is locked

2 participants

@pboling @apiology