Skip to content

Conversation

@stereosteve
Copy link

@stereosteve stereosteve commented Aug 21, 2019

  • Example test of using a parameter per docs
  • Fix some indentation spaces -> tabs

related: #30

@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files           6        6           
  Lines         326      326           
=======================================
  Hits          289      289           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263e564...81117e5. Read the comment docs.

@nezed
Copy link
Collaborator

nezed commented Oct 4, 2019

This is very interesting usage of params.
I'll take a closer look and i think it must be presented in README.

I'm not sure is this a good way to implement something like "prepared statements" or "escaped params" because of params implementations in CH HTTP interface.

Also as a part of #37 i'll cleanup codebase soon, so you will be able to push just a usefuls changes 🙃

@nezed nezed self-assigned this Oct 4, 2019
@nezed nezed self-requested a review October 4, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants