Open
Conversation
Member
|
Hey Fabian, these are really nice icons, and will look great on newer FxOS releases. However, in India, we only have 1.3 Tarako version released. And in most LatAm counties, they've got 1.1/1.2. Hence we followed that guideline, so that we know it's gonna be fully compatible with those devices. Do you have any links for the newer conventions/guides? Also, I'm keeping this open, but probably it won't be merged very soon (as only a couple of countries have seen 1.4+ FxOS releases). Once most release countries are on new FxOS builds, we'll come back to this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Icon will look better on 1.3+
I didn't follow the default icon design guidelines from here because they're outdated: https://www.mozilla.org/en-US/styleguide/products/firefox-os/icons
I'm following the new Icon design of 1.4 or 2.0+ (see it on the B2G Simulator) because it will look more consistent. Also, you don't really need a 512px icon, 284px is big enough.