Skip to content

Conversation

@PhantomInTheWire
Copy link

@PhantomInTheWire PhantomInTheWire commented Dec 16, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

related issue: #895

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@PhantomInTheWire PhantomInTheWire force-pushed the feat/containercp branch 2 times, most recently from 9e76056 to 8556a39 Compare December 16, 2025 23:21
@PhantomInTheWire PhantomInTheWire marked this pull request as ready for review December 16, 2025 23:22
@PhantomInTheWire PhantomInTheWire force-pushed the feat/containercp branch 4 times, most recently from 29976e3 to 37b9999 Compare December 20, 2025 01:43
@PhantomInTheWire PhantomInTheWire force-pushed the feat/containercp branch 2 times, most recently from 3e03971 to e83d9b9 Compare January 3, 2026 11:41
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Copy link
Contributor

@jglogan jglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PhantomInTheWire, sorry that it took a while to get to this one.

See the comment here regarding container cp. The same problem applies to a command like container volume cp.

What you have right now isn't copying into the volume. A volume is a sparse disk image file with an ext4 filesystem written inside it. From what I can tell, your code is copying files around the host (it doesn't build for me as the Archive type isn't found).

To copy in and out of a volume we'd need for the volume to not be used in a running container, and then we'd need to launch a utility container that mounts the volume, and then copy from host to the utility container using the equivalent of container cp.

What could be possible is to add a --from to the container volume create command that allows the user to initialize a new named volume using data on their host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants