Reduce mish error by an alternative without softplus op #2618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the high numerical error in mish activation #2359.
Algorithm:
Evaluation:
In the following experiments, the mean absolute errors are evaluated by the method in #2359 (comment).
Before this change, NE generates high numerical error:
With the new algorithm, NE generates low numerical error:
A tester reported that the new mish function generates
NaNonly whenxis-Infin the float16 format.Performance:
This change has been adopted in KataGo Core ML backend ChinChangYang/KataGo#7. The performance of the KataGo model with the new mish activation (7.15 ms) is similar to the original mish implementation (7.03 ms).
Conclusion:
Overall, the change enhances the accuracy and reliability of the mish activation in Core ML models.