Merged
Conversation
HT154
commented
Apr 14, 2026
Comment on lines
+23
to
+25
| output { | ||
| text = foo | ||
| } |
| // ===----------------------------------------------------------------------===// | ||
| @go.Package { name = "github.com/apple/pkl-go/codegen/snippet-tests/output/union" } | ||
| module union | ||
| extends "support/OpenModule.pkl" |
|
|
||
| /// Generates Go sources from Pkl | ||
| @ModuleInfo { minPklVersion = "0.29.0" } | ||
| @ModuleInfo { minPklVersion = "0.30.0" } |
Contributor
Author
There was a problem hiding this comment.
This is required because allModifiers was introduced in Pkl 0.30
HT154
commented
Apr 14, 2026
Comment on lines
+49
to
+51
| seen.add(decl) | ||
| |> gatherTypeArguments(decl) | ||
| |> (_seen) -> gatherTypeDeclarationsFromType(decl.referent, decl, _seen) |
HT154
commented
Apr 14, 2026
| function gatherPropertiesDeclarations(clazz: reflect.Class) = (seen: List<reflect.TypeDeclaration>) -> | ||
| clazz.properties.values | ||
| .filter((p) -> !p.modifiers.contains("hidden")) | ||
| .filter((p) -> !p.allModifiers.contains("hidden")) |
* Fix generation of properties that are hidden by a parent module but amended without modifier in a sub-module. * Fix generation of types defined in extending modules only reachable via a typealias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #233
Resolves #234