Open
Conversation
Member
|
Hey, thanks for the contribution! This seems a little too opinionated for something like pkl-pantry--the handling of nested values seems a little too tied to the dotenv library, and doesn't seem generally usable as a format. For that reason, I don't think pkl-pantry is the best fit for this. However, you don't need to submit this package here in order for it to be shareable. Feel free to publish it yourself as a GitHub release. When you do that, you can import the package via For an example of another package that's published independently, take a look at @jamesward's https://github.com/jamesward/pklgha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses apple/pkl#273.
I assumed the .env format defined by https://github.com/motdotla/dotenv.
Since .env can only represent single line value assignments (e.g., NAME="foo") the primary challenge was deciding how to simplify pkl structures. Here, I decided to minimize parsing for the .env consumer.
So, I chose the following conversions:
So,
becomes
And
becomes
Alternatively, array structures could be inlined, so that the above example would instead become
letting flattening be the responsibility of converters.
Thanks for reading!