Conversation
HT154
left a comment
There was a problem hiding this comment.
Approving to unblock, but a couple small things
| module.catalog.`actions/checkout@v6` | ||
| (module.catalog.`actions/setup-java@v5`) { | ||
| with { | ||
| `java-version` = "25" |
There was a problem hiding this comment.
Probably best to pull this out somewhere so it's not in multiple places in our GHA configs
There was a problem hiding this comment.
I can't think of an easy place to put this off the bat, so I'm just going to keep this as-is. Maybe we can refactor things, but I'll consider this as out-of-scope for now.
| jobs = (_jobs) { | ||
| ["dependency-submission"] = dependencySubmission | ||
| } |
There was a problem hiding this comment.
This is a little awkward. Can toWorkflowJobs just pass Workflow.Job instances through instead?
|
Looks like dependency submission needs permissions:
contents: writeDo we really need to be doing this on PRs? |
|
I have The goal was to have dependency changes reviewed by dependency-review-action, but I think we can try tackling that later (if at all). I'll remove that from the PRB builds. |
This adds jobs to add Gradle dependencies to GitHub's dependency submission API, and to review when these dependencies change.