-
Notifications
You must be signed in to change notification settings - Fork 348
Introduce tool info version 1 #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fork the tool info version 0 to a new stable version 1. Introduce a new '--help-dump-tool-info-v1' flag that functions similarly to '--experimental-dump-help'. Create a new ToolInfoV1 to keep the new types for the new schema. Update the tool info serialization version to 1. Add a JSON schema for the version 1 tool info format.
Format doc comments
@swift-ci please test |
@cmcgee1024 After Tool Info V1 has been merged in, do you want me to redo the completions script generation to use V1 instead of V0? Or is someone else already tasked with that? Should the migration be self explanatory or will there be any migration guide? |
The tool-info is practically identical between experimental and help-dump. Since the experimental flag remains in place, I think that existing integrations can safely rely on the v0 interface unless they have a reason to move off of it. This includes the shell completions, manual page, and docc markdown generators.
I expect that the migration will be self-explanatory with the same guide that explains the new tool-info v1 feature. Any suggestions of how to document this feature in SAP? |
Not sure exactly how to best document Tool Info. I learned V0 because Rauhul had me review his V0 refactor of the Bash completion script generation, but that was shelved in favor of my then in-process pre-Tool-Info rewrite of the completion generators (merging that before the Tool Info transition was much easier). I then migrated all the completions based on what I had learned from Rauhul's Bash migration for the older code. I think it was all straightforward. The only thing that didn't seem straightforward was why array values were allowed to be Maybe there's a reason why I'll probably migrate the completions after V1 has been merged, as long as no one else wants to do it, and as long as it isn't exceptionally onerous (which I doubt it would be). Thanks for all the info & all your PRs. |
Fork the tool info version 0 to a new stable version 1. Introduce a new '--help-dump-tool-info-v1' flag that functions similarly to '--experimental-dump-help'. Create a new ToolInfoV1 to keep the new types for the new schema. Update the tool info serialization version to 1. Add a JSON schema for the version 1 tool info format.
Checklist