Skip to content

Enable Windows CI #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable Windows CI #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ concurrency:
env:
SWIFTLINT_VERSION: 0.57.0
SWIFTFORMAT_VERSION: 0.54.6
SWIFT_HOMOMORPHIC_ENCRYPTION_ENABLE_BENCHMARKING: 1
jobs:
soundness:
name: soundness
Expand All @@ -29,7 +28,7 @@ jobs:
name: swifttests
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
with:
enable_windows_checks: false
linux_env_vars: "SWIFT_HOMOMORPHIC_ENCRYPTION_ENABLE_BENCHMARKING=1"
# TODO: remove 5.8 after https://github.com/swiftlang/github-workflows/pull/107
linux_exclude_swift_versions: "[{\"swift_version\": \"5.8\"}, {\"swift_version\": \"5.9\"}, {\"swift_version\": \"5.10\"}]"
linux_pre_build_command: "apt-get update && apt-get install -y libjemalloc-dev"
Expand All @@ -39,6 +38,19 @@ jobs:
basename=$(basename "$filename" .swift)
swift run --configuration release ${basename}
done
# TODO: remove 5.8 after https://github.com/swiftlang/github-workflows/pull/107
windows_exclude_swift_versions: "[{\"swift_version\": \"5.8\"}, {\"swift_version\": \"5.9\"}, {\"swift_version\": \"5.10\"}]"
# swift test --configuration release;
# $filenames = Get-ChildItem -Path Snippets\*.swift -Name -Recurse;
# $filenames = Get-ChildItem -Path Snippets\* -Include *.swift -Name -Recurse;
# ^-- didn't work
windows_build_command: >
$filenames = Get-ChildItem -Path .\Snippets\*.swift -Recurse -Name;
Write-Host "filenames: $filenames";
foreach ($filename in $filenames) {
basename = $(basename "$filename" .swift)
swift run --configuration release ${basename}
}
pre-commit:
timeout-minutes: 1
runs-on: ubuntu-22.04
Expand Down
27 changes: 17 additions & 10 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,16 +190,6 @@ let package = Package(
"HomomorphicEncryptionProtobuf",
"_TestUtilities",
], swiftSettings: executableSettings),
.testTarget(
name: "PIRGenerateDatabaseTests",
dependencies: ["PIRGenerateDatabase",
"_TestUtilities",
.product(name: "Numerics", package: "swift-numerics")], swiftSettings: executableSettings),
.testTarget(
name: "PIRProcessDatabaseTests",
dependencies: ["PIRProcessDatabase",
"_TestUtilities",
.product(name: "Numerics", package: "swift-numerics")], swiftSettings: executableSettings),
.testTarget(
name: "PrivateInformationRetrievalTests",
dependencies: [
Expand All @@ -226,6 +216,23 @@ let package = Package(
], swiftSettings: executableSettings),
])

// Workaround SwiftPM's attempt to link in executables which does not work on all
// platforms.
#if !os(Windows)
package.targets.append(contentsOf: [
.testTarget(
name: "PIRGenerateDatabaseTests",
dependencies: ["PIRGenerateDatabase",
"_TestUtilities",
.product(name: "Numerics", package: "swift-numerics")], swiftSettings: executableSettings),
.testTarget(
name: "PIRProcessDatabaseTests",
dependencies: ["PIRProcessDatabase",
"_TestUtilities",
.product(name: "Numerics", package: "swift-numerics")], swiftSettings: executableSettings),
])
#endif

// MARK: - Benchmarks

var enableBenchmarking: Bool {
Expand Down