Replace rethrows with typed throws in ByteBuffer #3372
+75
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Users who want to use typed throws would benefit from us propagating the thrown error type through our APIs. Most of our surface doesn't allow for that because it relies on standard library APIs that haven't been updated, but we can do it for ByteBuffer which is entirely ours. Modifications: - Adopt typed rethrows in ByteBuffer Result: Users have an easier time working with ByteBuffer
|
So this will be blocked behind us dropping 5.10. |
FranzBusch
approved these changes
Sep 15, 2025
| @@ -426,8 +426,12 @@ extension ByteBuffer { | |||
| /// - Returns: The number of bytes read. | |||
| @discardableResult | |||
| @inlinable | |||
| public mutating func readWithUnsafeReadableBytes(_ body: (UnsafeRawBufferPointer) throws -> Int) rethrows -> Int { | |||
| let bytesRead = try self.withUnsafeReadableBytes({ try body($0) }) | |||
| public mutating func readWithUnsafeReadableBytes<ErrorType: Error>( | |||
There was a problem hiding this comment.
NIT: In many other places the generic type is called Failure but not too important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Users who want to use typed throws would benefit from us propagating the thrown error type through our APIs. Most of our surface doesn't allow for that because it relies on standard library APIs that haven't been updated, but we can do it for ByteBuffer which is entirely ours.
Modifications:
Result:
Users have an easier time working with ByteBuffer