Open
Conversation
Contributor
LucRoy
commented
Jul 24, 2023
LucRoy
commented
- Changed /content endpoints to use gorm transaction.
- Pulled all datasets into a single query before looping through all content to be added.
jcace
reviewed
Jul 25, 2023
| } | ||
|
|
||
| cache := make(map[string]uint) | ||
| if err := dldm.DB.Model(&db.Dataset{}).Find(&datasets).Error; err != nil { |
Contributor
There was a problem hiding this comment.
Hmm, doesn't this .Find() only work on the primary key i.e, dataset ID ? We need to search via name instead here
Contributor
Author
There was a problem hiding this comment.
mmm here we are listing all datasets instead of querying per name. Let me know if you have a more efficient way of doing it.
Contributor
|
@LucRoy Looks good, will test as soon as you fix that one query! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.