Add ASME matching tensile analysis#5
Merged
reverendbedford merged 3 commits intomainfrom Jun 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new ASME-matching tensile analysis workflow and supporting correlation classes.
- Split the original ASME polynomial correlation into “Simple” and “Standard” variants with clear analyze implementations.
- Introduce
TensileDataAnalysisandASMETensileDataAnalysisfor dataset-driven yield and tensile regression. - Add
asme_tensile_analysishelper inmethods.pyfor constrained polynomial fitting.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pycreep/time_independent.py | Renamed and refactored ASME correlation classes; added TensileDataAnalysis and ASMETensileDataAnalysis. |
| pycreep/methods.py | Added asme_tensile_analysis for performing ASME-style constrained regression. |
Comments suppressed due to low confidence (3)
pycreep/time_independent.py:318
- The constructor for
StandardASMEPolynomialTimeIndependentCorrelationlistsF,S0, andT0but the docstring only describespoly. Please document all parameters (F,S0,T0, andpoly) with their purpose and units.
def __init__(self, F, S0, T0, poly, *args, **kwargs):
pycreep/time_independent.py:421
- The docstring states the default
analysis_temp_unitsis "K", but the code initializes it to "degC" unless overridden by the caller. Please align the documentation with the actual default or update the default setting in code.
default is "K"
pycreep/time_independent.py:279
- The
SimpleASMEPolynomialTimeIndependentCorrelationclass referencesself.F,self.S0,self.T0, andself.coefsin itsanalyzemethod without defining them in an__init__. Consider adding an initializer to set these attributes or inheriting parameters properly.
class SimpleASMEPolynomialTimeIndependentCorrelation(
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a method for tensile data analysis that exactly matches the ASME spreadsheet.