Skip to content

Add ASME matching tensile analysis#5

Merged
reverendbedford merged 3 commits intomainfrom
tensile_analysis
Jun 24, 2025
Merged

Add ASME matching tensile analysis#5
reverendbedford merged 3 commits intomainfrom
tensile_analysis

Conversation

@reverendbedford
Copy link
Contributor

Adds a method for tensile data analysis that exactly matches the ASME spreadsheet.

@reverendbedford reverendbedford requested a review from Copilot June 24, 2025 16:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new ASME-matching tensile analysis workflow and supporting correlation classes.

  • Split the original ASME polynomial correlation into “Simple” and “Standard” variants with clear analyze implementations.
  • Introduce TensileDataAnalysis and ASMETensileDataAnalysis for dataset-driven yield and tensile regression.
  • Add asme_tensile_analysis helper in methods.py for constrained polynomial fitting.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pycreep/time_independent.py Renamed and refactored ASME correlation classes; added TensileDataAnalysis and ASMETensileDataAnalysis.
pycreep/methods.py Added asme_tensile_analysis for performing ASME-style constrained regression.
Comments suppressed due to low confidence (3)

pycreep/time_independent.py:318

  • The constructor for StandardASMEPolynomialTimeIndependentCorrelation lists F, S0, and T0 but the docstring only describes poly. Please document all parameters (F, S0, T0, and poly) with their purpose and units.
    def __init__(self, F, S0, T0, poly, *args, **kwargs):

pycreep/time_independent.py:421

  • The docstring states the default analysis_temp_units is "K", but the code initializes it to "degC" unless overridden by the caller. Please align the documentation with the actual default or update the default setting in code.
                                    default is "K"

pycreep/time_independent.py:279

  • The SimpleASMEPolynomialTimeIndependentCorrelation class references self.F, self.S0, self.T0, and self.coefs in its analyze method without defining them in an __init__. Consider adding an initializer to set these attributes or inheriting parameters properly.
class SimpleASMEPolynomialTimeIndependentCorrelation(

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@reverendbedford reverendbedford merged commit 1bf4f3d into main Jun 24, 2025
3 checks passed
@reverendbedford reverendbedford deleted the tensile_analysis branch June 24, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants