Skip to content

Various small fixes to support AMMT demo#6

Merged
reverendbedford merged 3 commits intomainfrom
ammt_fixes
Jun 24, 2025
Merged

Various small fixes to support AMMT demo#6
reverendbedford merged 3 commits intomainfrom
ammt_fixes

Conversation

@reverendbedford
Copy link
Contributor

Minor fixes to support the dash demo.

@reverendbedford reverendbedford requested a review from Copilot June 24, 2025 16:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces several minor fixes to support the AMMT demo. Key changes include:

  • Improved handling of the confidence parameter in the TTP prediction method.
  • An updated signature for the predict_stress function in TTP with a new parameter to optionally raise errors.
  • Modification of the GPR predict_stress method to accept additional keyword arguments.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pycreep/ttp.py Updated predict_time logic and expanded predict_stress signature.
pycreep/gpr.py Altered predict_stress signature to accept extra kwargs.
Comments suppressed due to low confidence (2)

pycreep/ttp.py:256

  • Consider adding a comment explaining the rationale behind using np.sign(confidence) and np.abs(confidence) in this calculation, to clarify how negative confidence values are intended to be interpreted.
            h = np.sign(confidence) * scipy.stats.norm.interval(np.abs(confidence))[1]

pycreep/gpr.py:373

  • Consider explicitly defining any additional parameters expected in **kwargs to avoid potential ambiguity and to improve API clarity.
    def predict_stress(self, time, temperature, confidence=None, **kwargs):

@reverendbedford reverendbedford merged commit ab8dc3e into main Jun 24, 2025
3 checks passed
@reverendbedford reverendbedford deleted the ammt_fixes branch June 24, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants