Various small fixes to support AMMT demo#6
Merged
reverendbedford merged 3 commits intomainfrom Jun 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several minor fixes to support the AMMT demo. Key changes include:
- Improved handling of the confidence parameter in the TTP prediction method.
- An updated signature for the predict_stress function in TTP with a new parameter to optionally raise errors.
- Modification of the GPR predict_stress method to accept additional keyword arguments.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pycreep/ttp.py | Updated predict_time logic and expanded predict_stress signature. |
| pycreep/gpr.py | Altered predict_stress signature to accept extra kwargs. |
Comments suppressed due to low confidence (2)
pycreep/ttp.py:256
- Consider adding a comment explaining the rationale behind using np.sign(confidence) and np.abs(confidence) in this calculation, to clarify how negative confidence values are intended to be interpreted.
h = np.sign(confidence) * scipy.stats.norm.interval(np.abs(confidence))[1]
pycreep/gpr.py:373
- Consider explicitly defining any additional parameters expected in **kwargs to avoid potential ambiguity and to improve API clarity.
def predict_stress(self, time, temperature, confidence=None, **kwargs):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes to support the dash demo.