Draft
Conversation
[PBI-5122] * encryption support for logged in conversation
* rename roster with SHA256 and some clean up [PBI-5555]
* PBI-5055 JWT sub extract [PBI-5055] The ticket says we only need the sub claim from the JWT and the server will handle the rest of it. * lint * rename file * Add clarity to JwtUtils
[PBI-5583]
* delete old conversation & message files * Save conversation into a new file before deleting the old one [PBI-5572]
[PBI-5605] Add manifest structure change tests
* login & logout support
Update distribution name and version from configuration
* state machine support [PBI-5628]
Rename the payload ingestion method
Part 1 [PBI-4007] [PBI-4008] [PBI-5582]
* update conversation id and token for message manager and conversation service [PBI-4007] [PBI-4008] [PBI-5582]
… keyboard (#699) PBI-4322
… name (#701) PBI-5853
[PBI-7084]
…t get focus (#704) * linkify the question container only if it contains links * remove focus to non actionable item
* add the focusability in updateSelection [PBI-4323]
[PBI-6441]
[PBI-7937]
… AppActivity is null (#717) [PBI-7951][PBI-7953][PBI-7964]
| @@ -178,7 +180,12 @@ internal class ConversationManager( | |||
| val existingConversation = loadExistingConversation() | |||
| if (existingConversation != null) { | |||
| Log.i(CONVERSATION, "Loaded an existing conversation") | |||
Collaborator
Author
There was a problem hiding this comment.
Android fetches configuration after manifest expiry and the value serialized will be used. However, I cannot serialize metrics value as part of the configuration as it would break the entire serialization. Hence, using the shared pref to use it in between the launches.
| val configuration = conversation.configuration | ||
|
|
||
| if (isInThePast(configuration.expiry) || isDebuggable) { | ||
| if (isInThePast(configuration.expiry) || isDebuggable || !DependencyProvider.of<AndroidSharedPrefDataStore>().containsKey(SDK_CORE_INFO, METRICS_ENABLED)) { |
Collaborator
Author
There was a problem hiding this comment.
I had to add this check to ensure the Configuration is fetched if the metrics value is not found the shared pref which means the app is launched for the first time after enabling the metrics value.
| repositories { | ||
| google() | ||
| mavenCentral() | ||
| maven { |
Collaborator
Author
There was a problem hiding this comment.
Not relevant with the fix. But I need it if we are going to share the jfrog repo.
frankus
previously approved these changes
Apr 21, 2025
Use 6.9.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the latest code changes that we will be sharing with the customer addressing two android bugs.