Expose __version__ on pygrgl package#133
Merged
dcdehaas merged 1 commit intoaprilweilab:mainfrom Apr 30, 2026
Merged
Conversation
The C++ pybind module already sets _grgl.__version__ from GRGL_MAJOR_VERSION/GRGL_MINOR_VERSION in include/grgl/version.h, but pygrgl/grg.py uses 'from _grgl import *', which skips dunder names. As a result, pygrgl.__version__ was unset. Re-export it explicitly so version.h is the single source of truth for both setup.py and the importable package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_grgl.__version__is already set fromGRGL_MAJOR_VERSION/GRGL_MINOR_VERSIONininclude/grgl/version.h(seesrc/python/_grgl.cpp:1139-1141), butpygrgl/grg.pyusesfrom _grgl import *, which skips dunder names. As a resultpygrgl.__version__was unset.pygrgl/__init__.pysoversion.his the single source of truth for bothsetup.pyand the importable package.Test plan
python -c "import pygrgl; print(pygrgl.__version__)"prints2.7python -c "from pygrgl import __version__; print(__version__)"prints2.7