Large performance improvement to GRG modification#135
Merged
Conversation
Previously there were two performance problems with modifying GRG: 1. The Mutations were hard deleted from a std::vector, which resulted in an O(N) copy of data every remove_mutation() 2. The adding of a new Mutation flagged the mutation-to-node mapping to be resorted again on the next read access. This is overly aggressive IF AND ONLY IF you are adding Mutations to newly added nodes, then it is trivial to keep the mapping in the right sorted order by just appending to it.
AAce3
pushed a commit
to CornellHPC/grgl
that referenced
this pull request
May 7, 2026
Previously there were two performance problems with modifying GRG: 1. The Mutations were hard deleted from a std::vector, which resulted in an O(N) copy of data every remove_mutation() 2. The adding of a new Mutation flagged the mutation-to-node mapping to be resorted again on the next read access. This is overly aggressive IF AND ONLY IF you are adding Mutations to newly added nodes, then it is trivial to keep the mapping in the right sorted order by just appending to it.
AAce3
pushed a commit
to CornellHPC/grgl
that referenced
this pull request
May 7, 2026
Previously there were two performance problems with modifying GRG: 1. The Mutations were hard deleted from a std::vector, which resulted in an O(N) copy of data every remove_mutation() 2. The adding of a new Mutation flagged the mutation-to-node mapping to be resorted again on the next read access. This is overly aggressive IF AND ONLY IF you are adding Mutations to newly added nodes, then it is trivial to keep the mapping in the right sorted order by just appending to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there were two performance problems with modifying GRG: