Skip to content

return preStep global time #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

return preStep global time #439

merged 2 commits into from
Sep 19, 2025

Conversation

SeverinDiederichs
Copy link
Collaborator

Previously only the Track->globalTime and the postStepPoint->globalTime was set. This PR also returns and sets the preStepPoint->globalTime as required by Athena, CMSSW, and Gauss.

@SeverinDiederichs SeverinDiederichs added the enhancement Type: New feature or request label Sep 18, 2025
@phsft-bot
Copy link

Can one of the admins verify this patch?

JuanGonzalezCaminero
JuanGonzalezCaminero approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@JuanGonzalezCaminero JuanGonzalezCaminero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes!

@SeverinDiederichs SeverinDiederichs merged commit 8868e70 into apt-sim:master Sep 19, 2025
3 checks passed
@SeverinDiederichs SeverinDiederichs deleted the return_preStep_globalTime branch September 19, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGonzalezCaminero JuanGonzalezCaminero JuanGonzalezCaminero approved these changes

Assignees
No one assigned
Labels
enhancement Type: New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeverinDiederichs @phsft-bot @JuanGonzalezCaminero