EventDispatcher should be an Actor to prevent concurrent access / mutation of events.#33
Open
aswyer wants to merge 3 commits intoaptabase:mainfrom
Open
EventDispatcher should be an Actor to prevent concurrent access / mutation of events.#33aswyer wants to merge 3 commits intoaptabase:mainfrom
EventDispatcher should be an Actor to prevent concurrent access / mutation of events.#33aswyer wants to merge 3 commits intoaptabase:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #23 and #25.
EventDispatcherflush()is called from multiple places at the same time (ex: from individualTasks when called fromstopPolling()). This results in unsafe reads / mutations ofevents.Added a test to reproduce the bug that I've been experiencing and that is the same as the two linked issues.
Appreciate any thoughts on this fix!