Fix Daylight Savings Behavior #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UserNotFound
requested review from
eabruzzese and
eloisejones
and removed request for
UserNotFound and
krallin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issues raised in #86 and adds a few tests for the new behavior.
I included a brief explanation of the current erroneous behavior on the issue and pointed out that the fix may cause some potentially confusing behavior (
*/2 * * * *will have one hour between jobs when the DST boundary is divisible by two).This change also reuses the
crontest.layoutfor parsing in addition to its existing use for matching output. This required some adjustments the existing timestamp strings unrelated to the DST functionality.