Print sources details of snapshots and published repositories #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
reviewed
Jan 11, 2017
Contributor
smira
left a comment
smira
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks!
man/aptly.1
Outdated
| .\" http://github.com/rtomayko/ronn/tree/0.7.3 | ||
| . | ||
| .TH "APTLY" "1" "November 2016" "" "" | ||
| .TH "APTLY" "1" "2017-01-10" "" "" |
Contributor
There was a problem hiding this comment.
I didn't finish putting CONTRIBUTING notes yet, but upstream ronn has one bug (rtomayko/ronn#83) which is not patched. It leads to broken rendering of man page (and it's the reason for huge diff here).
I've got patched version here: https://github.com/smira/ronn
Probably I need to put some Makefile magic to pull in patched ronn and do transformation.
Contributor
Contributor
Author
|
@smira |
Contributor
|
Pushed as nightly |
sliverc
referenced
this pull request
in sliverc/pyaptly
Jan 19, 2017
This only works with aptly version >=0.9.8 (not released yet) as following change is needed: https://github.com/smira/aptly/pull/472
sliverc
referenced
this pull request
in sliverc/pyaptly
Jan 19, 2017
This only works with aptly version >=0.9.8 (not released yet) as following change is needed: https://github.com/smira/aptly/pull/472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
For aptly wrapper tools to work such as pyaptly it needs to know sources of a snapshots and published repositories.
Such details are currently part of the description. However such description is hard to parse (or also to read for humans compare aptly publish list) and not always applicable (e.g. when a snapshot has been renamed, merged etc.).
Hence it would be good to have a Sources printed in the snapshot show command and have an additional command publish show to show details of a published repository as well.
Such details may also be very helpful for command line users to get a clue what has been done.
Checklist
AUTHORS