Add support for publishing large packages to PackagePublisher#36
Open
Add support for publishing large packages to PackagePublisher#36
Conversation
davidiw
reviewed
Oct 21, 2024
Contributor
davidiw
left a comment
davidiw
left a comment
There was a problem hiding this comment.
this is still draft, let me know when it is ready for review.
- Updated `large_packages` Move module address - Downsized chunk size to 60KB - Made methods in PackagePublisher reusable in examples - Added object deployment and upgrade options for chunked publishing - Updated `large_package_publisher` example
…e compiling and publishing processes
0xjunha
force-pushed
the
large-package-publisher
branch
from
74e91ab to
3ab7f8d
Compare
Contributor
Author
|
Dependency resolved, and now is ready for review! @davidiw
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: The integration test will fail on localnet due to a dependency on this PR, which updates the function argument type in the large_packages.move module.
Note: Since the PackagePublisher doesn't include a Move compilation feature, users may face inconvenience having to manually derive object addresses where the large package will be deployed, as shown in the
examples/large_package_publisher.pyexample.large_packagesMove module addresslarge_package_publisherexampleTest Plan
Related Links