basic implementation of fungible asset client#7
Open
fishronsage wants to merge 1 commit intoaptos-labs:mainfrom
Open
basic implementation of fungible asset client#7fishronsage wants to merge 1 commit intoaptos-labs:mainfrom
fishronsage wants to merge 1 commit intoaptos-labs:mainfrom
Conversation
Contributor
Author
|
Hi, @davidiw, can you review this PR? |
Contributor
|
cc @gregnazario |
Contributor
|
how did I miss this?? |
davidiw
reviewed
Jun 4, 2024
Contributor
davidiw
left a comment
davidiw
left a comment
There was a problem hiding this comment.
I think this might suffice for a trivial FAC, but I kinda wanted to do the following:
- Make a generic object client from this https://github.com/aptos-labs/aptos-python-sdk/blob/main/aptos_sdk/aptos_token_client.py#L301
- Make it so that we have some framework to register the parsers or figure out some solution there
- Make FAC actually capable of reading the object
what do you think?
fishronsage
force-pushed
the
fa
branch
2 times, most recently
from
57e5bd4 to
2a1a5c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a basic Fungible Asset Client for Aptos FA