[rust] Update code to support 1.83 in clippy#5
Merged
gregnazario merged 2 commits intomainfrom Apr 24, 2025
Merged
Conversation
9d54415 to
9e385bc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to support Rust 1.83 in clippy by adjusting lint attributes, lifetime annotations, and CI tooling versions. Key changes include:
- Adjusting lint allow attributes in tests and source files (e.g. replacing
unit_argwith new Clippy lints). - Updating lifetime parameters in various Serialize/Deserialize trait implementations to use underscore lifetimes.
- Upgrading GitHub Actions versions and toolchain settings in CI workflows.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/serde.rs | Added a new lint allowance and updated constant usage from u64::max_value() to u64::MAX. |
| src/ser.rs | Replaced explicit lifetime parameters with underscore lifetimes in serializer trait implementations. |
| src/de.rs | Simplified lifetime declarations and updated Clippy lint allowances in deserializer implementations. |
| .github/workflows/rustdoc.yml | Upgraded GitHub Actions versions for repository checkout and docs deployment. |
| .github/workflows/ci.yml | Upgraded checkout action, updated toolchain version, and refined the clippy command to skip deps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.