Skip to content

Durga apty clone#532

Open
Saidurgasatturi wants to merge 2 commits intoaptyInc:mainfrom
Saidurgasatturi:durga-apty-clone
Open

Durga apty clone#532
Saidurgasatturi wants to merge 2 commits intoaptyInc:mainfrom
Saidurgasatturi:durga-apty-clone

Conversation

@Saidurgasatturi
Copy link
Copy Markdown

@Saidurgasatturi Saidurgasatturi commented Oct 7, 2025

Terms and Conditions

  • I Accept losing points if my PR does not follow the best practices mentioned below, which will impact my overall performance in training

HTML Best Practices

  • File Naming Convention:

  • Follow consistent and descriptive naming (e.g., dashboard.html, user-profile.html).

  • Use lowercase letters and hyphens instead of spaces.

  • Page Title:

  • Ensure the <title> tag is descriptive and aligns with the page content.

  • Include meaningful keywords for SEO if applicable.

  • Semantic Markup:

  • Use appropriate tags like <header>, <footer>, <section>, <article> for better readability and accessibility.

  • Accessibility Standards:

  • Ensure the use of alt attributes for images and proper labels for form elements.

  • Use ARIA roles where necessary.

  • Validation:

  • Ensure the code passes HTML validation tools without errors or warnings.

  • Structure and Indentation:

  • Maintain consistent indentation and proper nesting of tags.

  • Attributes:

  • Ensure all required attributes (e.g., src, href, type, etc.) are correctly used and not left empty.

CSS Best Practices

  • File Organization:

  • Use modular CSS files if applicable (e.g., base.css, layout.css, theme.css).

  • Avoid inline styles unless absolutely necessary.

  • Naming Conventions:

  • Use meaningful class names following BEM or other conventions (e.g., block__element--modifier).

  • Code Reusability:

  • Avoid duplicate code; use classes or mixins for shared styles.

  • Responsive Design:

  • Ensure proper usage of media queries for mobile, tablet, and desktop views.

  • Performance Optimization:

  • Minimize the use of unnecessary CSS selectors.

  • Avoid overly specific selectors and ensure selectors are not overly deep (e.g., avoid #id .class1 .class2 p).

  • Consistency:

  • Follow consistent spacing, indentation, and use of units (rem/em vs. px).

  • Maintain a single coding style (e.g., always use double or single quotes consistently).

Javascript Best Practices

  • File Organization:

  • Ensure scripts are modular and logically separated into files if needed.

  • Avoid mixing inline JavaScript with HTML.

  • Logic Optimization:

  • Check for redundancy and ensure the code is optimized for performance.

  • Avoid unnecessary API calls or DOM manipulations.

  • Solution Approach:

  • Confirm that the code solves the given problem efficiently.

  • Consider scalability for future enhancements.

  • Readability:

  • Use clear variable and function names.

  • Add comments for complex logic or algorithms.

  • Error Handling:

  • Ensure proper error handling for API calls or user input validation.

  • Code Quality:

  • Check for potential bugs (e.g., missing await, mishandling of null/undefined values).

  • Avoid unnecessary console.log statements in production code.

  • Security:

  • Avoid hardcoding sensitive data.

  • Sanitize user input to prevent XSS and other vulnerabilities.

  • Best Practices:

  • Use const and let instead of var.

  • Follow ES6+ standards where applicable.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @Saidurgasatturi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new web development content, likely as part of a training or assignment. It includes two distinct CSS exercises demonstrating fundamental concepts like responsive design and animations. The core of the PR is a detailed replication of the apty.ai website's homepage and free trial page, showcasing a broad range of HTML and CSS skills, including complex layouts, interactive components, and responsive adaptations. The author's explicit mention of best practices in the PR description indicates an emphasis on producing clean and well-structured code.

Highlights

  • New CSS Assignments: Two new CSS-focused assignments were added, demonstrating responsive layouts and CSS animations, showcasing fundamental web styling concepts.
  • Apty Website Clone: A significant portion of the PR involves cloning the apty.ai website, including its homepage and a free trial page, demonstrating comprehensive front-end development skills.
  • Comprehensive Styling: The apty-clone project features extensive CSS, showcasing advanced layout techniques, gradient effects, video backgrounds, and interactive elements for a modern web experience.
  • Adherence to Best Practices: The PR description highlights a commitment to HTML, CSS, and JavaScript best practices, indicating a focus on quality, maintainability, and structured code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several HTML and CSS files, including a clone of the Apty website. While the visual implementation is a good effort, there are numerous areas for improvement regarding code quality, best practices, and correctness. The code contains widespread use of inline CSS, <br> tags for styling, and several accessibility issues, such as unlinked form labels. The CSS file has multiple syntax errors, including missing units and invalid property values, redundant and conflicting style definitions, and poor color contrast choices. These issues impact maintainability, accessibility, and can cause rendering bugs. I've left specific comments with suggestions to address these points.

<a href="#" class="btn gradient">GET STARTED</a>

<div class="logos">
<img src="logos.png" alt="Logos" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The src attribute points to logos.png, but this image file is not included in the pull request. This will result in a broken image on the page. Please ensure all image assets are added to the repository.

.footer-bottom p {
font-family: 15px Poppins;
margin-left: 50px;
margin:auto
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This line is missing a semicolon at the end, which is a syntax error. While most browsers will recover, it's important to write valid CSS to avoid unexpected behavior.

  margin:auto;

}

.footer-bottom p {
font-family: 15px Poppins;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The font-family property value is invalid. It seems you've combined font-size and font-family. These should be separate properties. For a more concise approach, you can use the font shorthand property.

    font: 15px 'Poppins', sans-serif;

Comment on lines +23 to +24
height: 61;
width:109;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

CSS properties for height and width require units (e.g., px, em, rem, %). Without units, these values are invalid and may not render as expected across all browsers.

    height: 61px;
    width:109px;

height="500"
decoding="async"
src="https://apty.ai/wp-content/uploads/2024/08/infor-dashbaord.svg"
clas="enter1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a typo in the attribute name. It should be class instead of clas.

Suggested change
clas="enter1"
class="enter1"

Comment on lines +249 to +255
<br />
<p>Boost Employee Productivity by 2x</p>
<br />
<p>Reduce Operational Expenses by 35%</p>
<br />
<p>Lower IT Support Costs by 50%</p>
<br />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using <br /> tags for spacing is not a good practice. It's better to use CSS margins or padding on the <p> elements to control the layout. This makes the styling more consistent and maintainable.

<div class="card">
<img
src="https://apty.ai/wp-content/uploads/2025/08/business-people-working-as-a-good-team-in-the-offi-2024-12-19-20-07-06-utc-768x512.jpg"
alt=""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This image appears to be part of the content, but it has an empty alt attribute. For accessibility, content images must have descriptive alt text that conveys the same information as the image. Decorative images can have an empty alt attribute.

Suggested change
alt=""
alt="Business people working as a team in an office"

<li><img src="https://apty.ai/wp-content/uploads/2025/01/Frame-1000002830.svg"> Create product workflows</li>
<li><img src="https://apty.ai/wp-content/uploads/2025/01/Frame-1000002830.svg"> Personalize onboarding</li>
<li><img src="https://apty.ai/wp-content/uploads/2025/01/Frame-1000002830.svg"> Identify user drop-off points</li>
</ul><br>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <br> tag should not be used to create vertical space between elements. Use CSS properties like margin or padding for styling and layout. This provides better control and is semantically correct.

<div class="trial-text">
<h2 style="color: white;">Get more people <br><span>to use your SaaS application</span></h2>
<ul style="color: white;">
<li><img src="https://apty.ai/wp-content/uploads/2025/01/Frame-1000002830.svg"> Create product workflows</li>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This <img> tag is missing an alt attribute. For decorative images like this checkmark, you should provide an empty alt="". For images that convey information, the alt text should describe the image. This is crucial for accessibility.

Suggested change
<li><img src="https://apty.ai/wp-content/uploads/2025/01/Frame-1000002830.svg"> Create product workflows</li>
<li><img src="https://apty.ai/wp-content/uploads/2025/01/Frame-1000002830.svg" alt=""> Create product workflows</li>

.trial-form h4 {
margin-top: 25px;
font-size: 20px;
color: hwb(0 93% 1%);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The hwb() color function has limited browser support (it's not supported in all versions of Safari, for example). For better cross-browser compatibility, it's safer to use a more widely supported format like rgb(), hsl(), or a hex code. The equivalent for hwb(0 93% 1%) is #ededed.

  color: #ededed;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant