Skip to content

v1.6.1: Add OtherUser.inputAddUser and illegal channel bugfixes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2025

Conversation

aquamarine5
Copy link
Owner

No description provided.

@aquamarine5 aquamarine5 requested a review from Copilot May 10, 2025 02:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the application by introducing manual user input for adding other users, integrating sponsor popups across various sign screens, and adding illegal channel detection for improved security.

  • Adds new drawable assets and updates UI components for better user interaction.
  • Integrates SponsorPopupDialog logic in QRCode, Photo, and Location sign screens.
  • Implements illegal channel checks in MainActivity and ImportOtherUserActivity and updates related analytics and exception handling.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
res/drawable/ic_text_cursor_input.xml New vector drawable for text cursor input
res/drawable/ic_heart_handshake.xml New vector drawable for heart handshake icon
screen/QRCodeSignScreen.kt Added sponsor popup trigger based on sign user list conditions
screen/PhotoSignScreen.kt Integrated sponsor dialog trigger in photo-sign flow
screen/OtherUserScreen.kt Added manual input dialog for other user addition and updated segmented button UI
screen/LocationSignScreen.kt Modified sponsor trigger logic in location sign flow
components/SponsorPopupDialog.kt Introduced SponsorPopupDialog with randomized display behavior
components/SponsorAlertDialog.kt Updated drawable references for sponsor alert dialog
components/GetLocationComponent.kt Revised location client initialization using LaunchedEffect
api/ChaoxingHttpClient.kt Removed datastore update during login session handling
UMengHelper.kt Added illegal channel event and md5 helper function
MainActivity.kt Implemented illegal channel detection and exception handling
ImportOtherUserActivity.kt Added illegal channel check for user import activity
ChaoxingPredictableException.kt Introduced ApplicationIllegalChannelException subtype
app/build.gradle Bumped versionCode and versionName for the release

aquamarine5 and others added 2 commits May 10, 2025 10:42
…/components/SponsorPopupDialog.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/screen/LocationSignScreen.kt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aquamarine5 aquamarine5 merged commit 57c466a into main May 10, 2025
2 checks passed
Copy link

sentry-io bot commented May 11, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ DiagnosticCoroutineContextException org.aquamarine5.brainspark.chaoxingsignfaker.sc... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant