Draft
Conversation
Satevg
commented
Oct 17, 2023
src/main.ts
Outdated
|
|
||
| if (!diffChecker.checkIfTestCoverageFallsBelowDelta(delta)) { | ||
| const gif = await getGiphyGifForTag('happy dog') | ||
| const gif = await getGiphyGifForTag('happy cat') |
Author
|
Marked as draft, so that it's not possible to accidentally merge this into master |
rself-ig
reviewed
Oct 17, 2023
Satevg
force-pushed
the
s3-coverage-comparison
branch
from
225fe23 to
7c23e2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://aquicore.atlassian.net/browse/AQ-15182
Frontend repository uses this branch to calculate coverage with remote S3 file as a base.
This might break services pipelines (except frontend) that rely on
aquicore/Jest-Coverage-Diff