Skip to content

Conversation

@atticusofsparta
Copy link
Contributor

@atticusofsparta atticusofsparta commented Jan 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated deployment workflow to use an improved action version for enhanced reliability
    • Added new build scripts for optimized production and development environments

✏️ Tip: You can customize this high-level summary in your review settings.

@atticusofsparta atticusofsparta requested a review from a team as a code owner January 14, 2026 18:39
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

This pull request updates the GitHub Actions workflow to use a newer version (v0.1.0) of the permaweb-deploy action and adds two new npm build scripts (build:production and build:develop) that configure environment variables for different build environments.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/pr-preview.yaml
Updated permaweb-deploy action from v0.0.2 to v0.1.0 in the PR preview deployment step.
Build Scripts
package.json
Added two new npm scripts: build:production and build:develop, each setting NODE_OPTIONS and VITE environment variables before invoking vite build.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • dtfiedler
  • kunstmusik

Poem

🐰 A version bump here, scripts deployed with care,
Production and dev builds now float through the air,
With VITE and NODE_OPTIONS set just right,
The rabbit hops onward toward build-day delight! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix(actions): bump permaweb-deploy action version' accurately describes the main change in the changeset—updating the permaweb-deploy action from v0.0.2 to v0.1.0 in the workflow file. However, the changeset also includes significant additions to package.json (two new build scripts), which are not reflected in the title.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


🧹 Recent nitpick comments
package.json (1)

8-9: New build scripts look good.

The scripts provide convenient environment-specific builds with proper cross-env usage.

Minor observation: Consider using development instead of develop for consistency with common conventions (e.g., NODE_ENV=development). Currently, the workflow uses VITE_NODE_ENV: production, which aligns with build:production.

💅 Optional: Use conventional naming
-    "build:develop": "yarn clean && cross-env NODE_OPTIONS=--max-old-space-size=32768 VITE_NODE_ENV=develop VITE_ENVIRONMENT=develop vite build",
+    "build:develop": "yarn clean && cross-env NODE_OPTIONS=--max-old-space-size=32768 VITE_NODE_ENV=development VITE_ENVIRONMENT=development vite build",

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5f9916 and d3552f9.

📒 Files selected for processing (2)
  • .github/workflows/pr-preview.yaml
  • package.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: dtfiedler
Repo: ar-io/arns-react PR: 904
File: .github/workflows/pr-preview.yaml:52-58
Timestamp: 2025-12-16T16:47:36.348Z
Learning: In the ar-io/arns-react repository, ArNS undername cleanup for PR previews is handled by the permaweb-deploy GitHub action, not by a local script in this repository. The cleanup step should not be included in the PR preview workflow.
📚 Learning: 2025-12-16T16:47:36.348Z
Learnt from: dtfiedler
Repo: ar-io/arns-react PR: 904
File: .github/workflows/pr-preview.yaml:52-58
Timestamp: 2025-12-16T16:47:36.348Z
Learning: In the ar-io/arns-react repository, ArNS undername cleanup for PR previews is handled by the permaweb-deploy GitHub action, not by a local script in this repository. The cleanup step should not be included in the PR preview workflow.

Applied to files:

  • .github/workflows/pr-preview.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: deploy-preview
  • GitHub Check: lint_test_build
🔇 Additional comments (1)
.github/workflows/pr-preview.yaml (1)

48-48: Version upgrade to v0.1.0 is safe and compatible.

The action version adds optional caching support (use-cache input with sensible defaults) without breaking changes. All existing inputs used by this workflow remain unchanged and fully compatible. This aligns with the learnings that the permaweb-deploy action handles ArNS undername cleanup for PR previews.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Permaweb Preview Deployed

Your preview is available at: https://arns-react-pr-914_arns.ar.io

Property Value
Transaction ID AaschsNQ6XxLxEELwpjw9vM7xwRcJJJwMX6j-b7vhCw
ArNS Name arns
Undername arns-react-pr-914

This preview will be available permanently on Arweave via the AR.IO Network.

@atticusofsparta atticusofsparta merged commit c28b78f into develop Jan 16, 2026
9 checks passed
@atticusofsparta atticusofsparta deleted the update-permaweb-deploy-action branch January 16, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants