Skip to content

[MISC] Move isDarkTheme prop into setup hook #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zak39 merged 1 commit into from
Jan 5, 2026
Merged

[MISC] Move isDarkTheme prop into setup hook #1564

zak39 merged 1 commit into from
Jan 5, 2026

Conversation

@zak39
Copy link
Collaborator

@zak39 zak39 commented Dec 30, 2025

Before

before-console-error-with-dark-theme-function-in-datastore.webm

After

after-console-error-with-dark-theme-function-in-datastore.webm

@zak39 zak39 added this to the v4.3.0 milestone Dec 30, 2025
@zak39 zak39 requested a review from smarinier December 30, 2025 16:19
@zak39 zak39 self-assigned this Dec 30, 2025
@zak39 zak39 added frontend Modification related to frontend debug Ongoing correction labels Dec 30, 2025
@zak39 zak39 merged commit 69b4ac7 into main Jan 5, 2026
5 checks passed
@zak39 zak39 deleted the fix/move-useIsDarkTheme-to-setup branch January 5, 2026 13:53
@zak39 zak39 mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarinier smarinier Awaiting requested review from smarinier

Assignees

@zak39 zak39

Labels

debug Ongoing correction frontend Modification related to frontend

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zak39