refactor(php): Using native PHP8.0 attributes #813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zak39
added
forStable27
Collaborator
Author
|
I confirm, this PR it's for stable27 only. We don't accept it for the moment... |
Collaborator
Author
|
You can review my PR after the rebase this branch. |
zak39
force-pushed
the
refactor/use-attributes-php8
branch
from
8e12a8e to
c0bffe3
Compare
zak39
force-pushed
the
refactor/use-attributes-php8
branch
from
22bc802 to
f9025d3
Compare
zak39
force-pushed
the
refactor/use-attributes-php8
branch
from
f9025d3 to
980c997
Compare
zak39
force-pushed
the
refactor/use-attributes-php8
branch
from
980c997 to
bb719fc
Compare
zak39
force-pushed
the
refactor/use-attributes-php8
branch
from
bb719fc to
121249c
Compare
zak39
force-pushed
the
refactor/use-attributes-php8
branch
from
121249c to
9219507
Compare
It works with native PHP8.0 and for NC27 only. For the moment at least... link: https://help.nextcloud.com/t/how-should-we-use-php8-attributes/104278 Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
…oller file Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
zak39
force-pushed
the
refactor/use-attributes-php8
branch
from
6683243 to
7a51e4c
Compare
…ware I added an extra parameter to register the IsGeneralManager Middleware.
Collaborator
|
@zak39 What about this PR? Is it still relevant? |
Collaborator
Author
|
I close this PR, it's replaced by PR #1362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works with native PHP8.0 and for NC27 only.
For the moment at least...
I would like to check if it works on the NC26.
@acdmft , please, don't accept this PR for the moment 🙏
link: https://help.nextcloud.com/t/how-should-we-use-php8-attributes/104278