Conversation
bump version of gradle & asciidoctor plugins
|
Great, you did what I want. 👍 PS: I can help review this PR. I know Chinese and English. |
I first translated it with AI, and then manually adjusted it . |
|
@dannyge - THANX for providing this translation. In the last few years, a few people offered their support for translations, but nobody managed to actually FINISH it :-) Usually the process for adding a new (official) language is the following: |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds Chinese (Simplified Chinese, ZH) language support to the arc42 architecture documentation template. The changes include a complete translation of all 12 sections of the arc42 template to Chinese, along with necessary build configuration updates to support Chinese character rendering in PDFs.
Key changes:
- Complete Chinese translation of all arc42 template sections (01-12)
- Build configuration updates for Chinese language support
- Custom PDF theme configuration with Chinese fonts for proper character rendering
- Addition of Chinese-specific images and diagrams
Reviewed Changes
Copilot reviewed 19 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Added ZH to the list of supported languages |
| first-commits-per-language.sh | Added ZH to the language array for commit tracking |
| build.gradle | Added asciidoctorj PDF version configuration and Chinese PDF theme loading logic |
| ZH/version.properties | Created version metadata for Chinese translation |
| ZH/asciidoc/src/*.adoc | Created all 12 Chinese translated template sections plus config and about files |
| ZH/asciidoc/pdf-theme/zh-theme.yml | Created PDF theme configuration with Noto Sans SC font for Chinese |
| ZH/asciidoc/arc42-template.adoc | Created main Chinese template file that includes all sections |
| images/05_building_blocks-ZH.drawio.png | Added Chinese version of building blocks diagram |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
hhm - finding volunteers seems to be difficult this time. |
node
left a comment
node
left a comment
There was a problem hiding this comment.
I tried my best to take about 1 week to review these works, but there is still no guarantee that all problems can be checked.
Thanks for your contribution.
| 某些概念可能涉及系统的 **所有** 元素，其他概念可能仅与少数元素相关。 | ||
| 在上图中，日志记录涉及所有三个构件，而安全性仅与两个构件相关。 | ||
|
|
||
| 参见 arc42 文档中的 https://docs.arc42.org/section-8/[概念]。 |
There was a problem hiding this comment.
这里与英文版本可能有滞后，原文还有 “背景” 和 “示例” 两个部分的内容，待检查确认。
There was a problem hiding this comment.
我检查了一下 master 分支上英文版本的内容，好像没有滞后。
There was a problem hiding this comment.
@node
十分感谢您能帮忙审核，我已经您的按照的建议修改了一个版本，剩余几处修改我不确定调整的是否合适，需要您抽空再帮忙确认一下：
- #224 (comment) (文件视图：https://github.com/arc42/arc42-template/pull/224/files#r2488378209 )
- #224 (comment)
- #224 (comment) (文件视图：https://github.com/arc42/arc42-template/pull/224/files#r2492787396 )
另外可能还有两个问题还没有结论(确定后还需要做调整):
building block的中文翻译: #224 (comment)- "简体中文"的
language code的选择(及连带的改造方案): #223 (comment)
Co-authored-by: DannyGe <dannyge@users.noreply.github.com>
|
first time that I have to review a PR where I cannot understand most of the things discussed :-) and THANX to you both for investing time and energy here!! Highly appreciated. |
It shows that Copilot can review together, but be useless here 😞 |
This pull request introduces a Simplified Chinese (ZH) translation of the arc42 architecture documentation template, including configuration, content, and build support. The changes add comprehensive AsciiDoc source files for all template sections, configuration for Chinese fonts in PDF output, and update build and reporting scripts to support the new language.
Major additions and improvements:
1. Chinese arc42 template content
ZH/asciidoc/src/, including introduction, architecture constraints, context, solution strategy, building blocks, runtime, deployment, concepts, decisions, quality requirements, risks, and glossary, with help texts and placeholders for user content.2. Template configuration and PDF theme
ZH/asciidoc/arc42-template.adocas the main entry point for the Chinese template, including all section files and help texts.ZH/asciidoc/pdf-theme/zh-theme.ymlto configure Noto Sans SC font family for proper Chinese PDF rendering.ZH/asciidoc/src/config.adocfor Chinese-specific AsciiDoc settings and captions.3. Build and versioning support
gradle.propertiesto includeZHin the list of languages to be built.ZH/version.propertiesto specify the template version, date, and remark for the Chinese edition.4. Script and reporting updates
first-commits-per-language.shto recognize and report the first commit for the ZH language.Summary:
This PR provides a full-featured Simplified Chinese version of the arc42 template, enabling Chinese-speaking teams to document software architectures using arc42 in their native language, with proper font and build support.
Generated by @codepliot