Skip to content

chore: fix outdated tests using outdated node runtimes #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmaj merged 2 commits into from
Dec 23, 2025
Merged

chore: fix outdated tests using outdated node runtimes #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da50115
drop use of no longer supported node runtime from mock projects
filmaj Dec 23, 2025
676f096
fix outdated runtime usage in integration tests
filmaj Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions test/integration/http/http-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,17 +166,17 @@ function runTests (runType, t) {
})
})

t.test(`${mode} get /nodejs22.x`, t => {
t.test(`${mode} get /nodejs24.x`, t => {
t.plan(15)
let rawPath = '/nodejs22.x'
let rawPath = '/nodejs24.x'
tiny.get({
url: url + rawPath,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs22.x (running nodejs22.x)',
routeKey: 'GET /nodejs22.x',
message: 'Hello from get /nodejs24.x (running nodejs24.x)',
routeKey: 'GET /nodejs24.x',
rawPath,
pathParameters: undefined,
cookies: undefined,
Expand All @@ -190,17 +190,17 @@ function runTests (runType, t) {
})
})

t.test(`${mode} get /nodejs20.x`, t => {
t.test(`${mode} get /nodejs22.x`, t => {
t.plan(15)
let rawPath = '/nodejs20.x'
let rawPath = '/nodejs22.x'
tiny.get({
url: url + rawPath,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs20.x (running nodejs20.x)',
routeKey: 'GET /nodejs20.x',
message: 'Hello from get /nodejs22.x (running nodejs22.x)',
routeKey: 'GET /nodejs22.x',
rawPath,
pathParameters: undefined,
cookies: undefined,
Expand All @@ -214,17 +214,17 @@ function runTests (runType, t) {
})
})

t.test(`${mode} get /nodejs18.x`, t => {
t.test(`${mode} get /nodejs20.x`, t => {
t.plan(15)
let rawPath = '/nodejs18.x'
let rawPath = '/nodejs20.x'
tiny.get({
url: url + rawPath,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs18.x (running nodejs18.x)',
routeKey: 'GET /nodejs18.x',
message: 'Hello from get /nodejs20.x (running nodejs20.x)',
routeKey: 'GET /nodejs20.x',
rawPath,
pathParameters: undefined,
cookies: undefined,
Expand Down
18 changes: 9 additions & 9 deletions test/integration/http/httpv1-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,16 @@ function runTests (runType, t) {
})
})

t.test(`${mode} get /nodejs22.x`, t => {
t.test(`${mode} get /nodejs24.x`, t => {
t.plan(16)
let path = '/nodejs22.x'
let path = '/nodejs24.x'
tiny.get({
url: url + path,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs22.x (running nodejs22.x)',
message: 'Hello from get /nodejs24.x (running nodejs24.x)',
resource: path,
path,
httpMethod: 'GET',
Expand All @@ -153,16 +153,16 @@ function runTests (runType, t) {
})
})

t.test(`${mode} get /nodejs20.x`, t => {
t.test(`${mode} get /nodejs22.x`, t => {
t.plan(16)
let path = '/nodejs20.x'
let path = '/nodejs22.x'
tiny.get({
url: url + path,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs20.x (running nodejs20.x)',
message: 'Hello from get /nodejs22.x (running nodejs22.x)',
resource: path,
path,
httpMethod: 'GET',
Expand All @@ -178,16 +178,16 @@ function runTests (runType, t) {
})
})

t.test(`${mode} get /nodejs18.x`, t => {
t.test(`${mode} get /nodejs20.x`, t => {
t.plan(16)
let path = '/nodejs18.x'
let path = '/nodejs20.x'
tiny.get({
url: url + path,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs18.x (running nodejs18.x)',
message: 'Hello from get /nodejs20.x (running nodejs20.x)',
resource: path,
path,
httpMethod: 'GET',
Expand Down
18 changes: 9 additions & 9 deletions test/integration/http/rest-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,16 @@ function runTests (runType) {
})
})

test(`${mode} get /nodejs22.x`, t => {
test(`${mode} get /nodejs24.x`, t => {
t.plan(16)
let path = '/nodejs22.x'
let path = '/nodejs24.x'
tiny.get({
url: url + path,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs22.x (running nodejs22.x)',
message: 'Hello from get /nodejs24.x (running nodejs24.x)',
resource: path,
path,
httpMethod: 'GET',
Expand All @@ -153,16 +153,16 @@ function runTests (runType) {
})
})

test(`${mode} get /nodejs20.x`, t => {
test(`${mode} get /nodejs22.x`, t => {
t.plan(16)
let path = '/nodejs20.x'
let path = '/nodejs22.x'
tiny.get({
url: url + path,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs20.x (running nodejs20.x)',
message: 'Hello from get /nodejs22.x (running nodejs22.x)',
resource: path,
path,
httpMethod: 'GET',
Expand All @@ -178,16 +178,16 @@ function runTests (runType) {
})
})

test(`${mode} get /nodejs18.x`, t => {
test(`${mode} get /nodejs20.x`, t => {
t.plan(16)
let path = '/nodejs18.x'
let path = '/nodejs20.x'
tiny.get({
url: url + path,
}, function _got (err, result) {
if (err) t.end(err)
else {
checkResult(t, result.body, {
message: 'Hello from get /nodejs18.x (running nodejs18.x)',
message: 'Hello from get /nodejs20.x (running nodejs20.x)',
resource: path,
path,
httpMethod: 'GET',
Expand Down
2 changes: 1 addition & 1 deletion test/mock/no-index-fail/src/http/get-foo/config.arc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@aws
runtime nodejs18.x
runtime nodejs24.x
# timeout 30
# concurrency 1
# memory 1152
2 changes: 1 addition & 1 deletion test/mock/no-index-pass/src/http/get-foo/config.arc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@aws
runtime nodejs18.x
runtime nodejs24.x
# timeout 30
# concurrency 1
# memory 1152
2 changes: 1 addition & 1 deletion test/mock/normal/app.arc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ queue-custom
@http
get / # runs default
# Runtimes
get /nodejs24.x
get /nodejs22.x
get /nodejs20.x
get /nodejs18.x
get /node-esm
get /python3.13
get /python3.9
Expand Down
2 changes: 1 addition & 1 deletion ...normal/src/http/get-nodejs18_x/config.arc → ...normal/src/http/get-nodejs24_x/config.arc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@aws
runtime nodejs18.x
runtime nodejs24.x
timeout 12
# concurrency 1
# memory 1152
2 changes: 1 addition & 1 deletion ...k/normal/src/http/get-nodejs18_x/index.js → ...k/normal/src/http/get-nodejs24_x/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
exports.handler = async (event) => {
const body = event
body.message = 'Hello from get /nodejs18.x (running nodejs18.x)'
body.message = 'Hello from get /nodejs24.x (running nodejs24.x)'
return {
statusCode: 200,
headers: { 'content-type': 'application/json' },
Expand Down
2 changes: 1 addition & 1 deletion test/mock/root-handling/greedy-get-index/src/http/get-index/config.arc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@aws
runtime nodejs18.x
runtime nodejs24.x
timeout 10
# concurrency 1
# memory 1152
2 changes: 1 addition & 1 deletion test/mock/root-handling/param-exact/src/http/get-000param-there/config.arc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@aws
runtime nodejs18.x
runtime nodejs24.x
timeout 10
# concurrency 1
# memory 1152
2 changes: 1 addition & 1 deletion test/mock/root-handling/root-param/src/http/get-000param/config.arc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@aws
runtime nodejs18.x
runtime nodejs24.x
timeout 10
# concurrency 1
# memory 1152