Feature / add conjunction type to jupiter moons class#29
Open
Cannikev wants to merge 3 commits intoarchitest:masterfrom
Open
Feature / add conjunction type to jupiter moons class#29Cannikev wants to merge 3 commits intoarchitest:masterfrom
Cannikev wants to merge 3 commits intoarchitest:masterfrom
Conversation
* add Conjunction Type to test_is_phenomena(self) * test if conjuction type is present during conjection (True/ False) * Refactored test_is_phenomena(self) to remove TOL (not required) * Refactored test_is_phenomena(self) to include Callisto for consistency * add Conjunction Type to is_phenomena(epoch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_jupiterMoons.py
JupiterMoons.py
Probably should have verified before I made the PR - There was a couple of ways that I could have approached this, shout if you prefer the second option.
Current Implementation:
Example:
Where:
Option 2: This may be a bit neater, but it will break any existing implementation that may already be in use.
Example:
Where: