Skip to content

Feature / add conjunction type to jupiter moons class#29

Open
Cannikev wants to merge 3 commits intoarchitest:masterfrom
Cannikev:feature-/-add-conjunction-type-to-jupiter-moons-class
Open

Feature / add conjunction type to jupiter moons class#29
Cannikev wants to merge 3 commits intoarchitest:masterfrom
Cannikev:feature-/-add-conjunction-type-to-jupiter-moons-class

Conversation

@Cannikev
Copy link
Contributor

@Cannikev Cannikev commented Jan 14, 2025

test_jupiterMoons.py

  • add occultation Type to test_is_phenomena(self)
  • test if occultation type is present during occultation(True/ False)
  • Refactored test_is_phenomena(self) to remove TOL (not required)
  • Refactored test_is_phenomena(self) to include Callisto

JupiterMoons.py

  • add Conjunction Type to is_phenomena(epoch)
  • Update examples

Probably should have verified before I made the PR - There was a couple of ways that I could have approached this, shout if you prefer the second option.

Current Implementation:
Example:

result_matrix=
[False, True, [None, True]]
[False, False, [None, None]]
[False, False, [None, None]]
[False, False, [None, None]]

Where:

    # Structure of result matrix
    # Row 0: Io            Column 0: Earth Occultation
    # Row 1: Europa        Column 1: Sun Occultation
    # Row 2: Ganymede      Column 2: Occultation Type  [Earth-Superior Conjunction, Sun-Superior Conjunction]
    # Row 3: Callisto      

    # Occultation Type (Superior Conjunction)
    # Column 1: Earth-Superior Conjunction (True: Jupiter occults moon, False: moon transits jupiter)
    # Column 2: Sun-Superior Conjunction (True: moon enters eclipse, False: shadow transits jupiter)

Option 2: This may be a bit neater, but it will break any existing implementation that may already be in use.
Example:

result_matrix =
[0, 1, None]
[0, 0, None]
[0, 0, None]
[0, 0, None]

Where:

    # Structure of result matrix
    # Row 0: Io            Column 0: 0=No occultation, 1=Moon in occultation, 2=Moon in transit
    # Row 1: Europa        Column 1: 0=No eclipse, 1=Moon in eclipse, 2=Moon shadow in transit
    # Row 2: Ganymede      Column 2: Not used
    # Row 3: Callisto    

* add Conjunction Type to test_is_phenomena(self)
* test if conjuction type is present during conjection (True/ False)
* Refactored test_is_phenomena(self) to remove TOL (not required)
* Refactored test_is_phenomena(self) to include Callisto for consistency
* add Conjunction Type to is_phenomena(epoch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant