Expose component IDs in ArcweaveAttributeValueData and add JSON parsi… #10
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng logic Added ComponentIds array to support component-list attributes and updated ParseAttributeValue to parse component IDs from JSON.
Collaborator
|
@aloussenim thank you for your contribution! We just updated our plugin with several changes during the installation and compilation of the plugin and some warning fixes for deprecations (that's why you have some conflicts now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a ComponentIds array to support component-list attributes and updated ParseAttributeValue to parse component IDs from JSON.
In our project, we are using Components extensively, and since they're in the json, we hoped this change was small enough to be considered an ok addition to your codebase :).
Tested locally with our project, works well.