refactor: added version info to settings sheet#42
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds app version information to the Settings bottom sheet so users can see what build they’re running.
Changes:
- Added a new
versionTextTextViewto the settings layout. - Populated the version label at runtime using
BuildConfig.VERSION_NAME. - Enabled
buildConfiggeneration in the app module build features.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/src/main/res/layout/fragment_settings.xml | Adds a footer-style version label and adjusts constraints in the settings sheet layout. |
| app/src/main/java/net/ardevd/tagius/features/settings/ui/SettingsBottomSheet.kt | Sets the version label text from BuildConfig.VERSION_NAME during view creation. |
| app/build.gradle.kts | Enables BuildConfig generation so VERSION_NAME can be referenced. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+33
| // Show version info | ||
| val version = BuildConfig.VERSION_NAME | ||
| binding.versionText.text = "v$version" | ||
|
|
There was a problem hiding this comment.
The version label is built with a hardcoded prefix ("v$version"). For localization and consistency with Android string handling, prefer a formatted string resource (e.g., @string/settings_version_format with %1$s) and set binding.versionText.text = getString(...).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.