Add save hex option and update Sketch menu #2458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Have "Save Hex" option (with Ctrl + Shift + R as well) * Move Upload and Upload w/ Programmer into Sketch menu as they are functions of sketch and not file technically Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
Contributor
|
Thanks @championswimmer. I see you used native commands for copying the hex file into the target folder. I think we can do that in java instead, saving some headaches (I already see an email from a Windows 12 user from the future, and discovering the "copy" command has different parameter names) |
Contributor
Author
|
Sure I'll do that |
Contributor
Author
Member
|
Closing in favor of #2567. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as they are functions of sketch and not file technically