-
-
Notifications
You must be signed in to change notification settings - Fork 36
board: add support for the Arduino Nano Matter #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
variants/arduino_nano_matter_mgm240sd22vna/arduino_nano_matter_mgm240sd22vna.overlay
Outdated
Show resolved
Hide resolved
pillo79
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning the new required tool in the PR notes. Please add it to extra/artifacts/_common.json so that CI generates the correct files automatically.
Without the return statement on alloc failure 'flash_area_read' gets an uninitialized pointer.
Thank you for the pointer, I've added it. Could you please check if it's correct? |
| "version": "0.0.4-rc.4" | ||
| }, | ||
| { | ||
| "packager": "arduino", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that tool is published under your own packager, so it should be:
| "packager": "arduino", | |
| "packager": "SiliconLabs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the tool looks like in the Silabs Arduino Core package JSON:
"name": "openocd",
"version": "0.12.0-arduino1-static",
"systems": [
{
"host": "i686-mingw32",
"url": "https://downloads.arduino.cc/tools/openocd-0.12.0-arduino1-static-i686-w64-mingw32.tar.bz2",
"archiveFileName": "openocd-0.12.0-arduino1-static-i686-w64-mingw32.tar.bz2",
"size": "2352177",
"checksum": "SHA-256:91ef6e8c9abdbcf8c97040b7045a620280716ab542629c2310e44b855475f807"
},
{
"host": "x86_64-apple-darwin",
"url": "https://downloads.arduino.cc/tools/openocd-0.12.0-arduino1-static-x86_64-apple-darwin19.tar.bz2",
"archiveFileName": "openocd-0.12.0-arduino1-static-x86_64-apple-darwin19.tar.bz2",
"size": "2041728",
"checksum": "SHA-256:098def8648d19a98f437c2b9458743bd78e6093b6883b67d52262dd73482ce31"
},
{
"host": "x86_64-pc-linux-gnu",
"url": "https://downloads.arduino.cc/tools/openocd-0.12.0-arduino1-static-x86_64-ubuntu16.04-linux-gnu.tar.bz2",
"archiveFileName": "openocd-0.12.0-arduino1-static-x86_64-ubuntu16.04-linux-gnu.tar.bz2",
"size": "6478337",
"checksum": "SHA-256:c48b4b348a68c3394e29fb7469a9eadf815a029e223b1612faff86bf4e7f053c"
}
]
It's a fork of OpenOCD that Martino made and is hosted on downloads.arduino.cc - so it's technically coming from you. Does the packager field determine the URL for download? If it's just a text and it'll work after changing it I'll change it :)
Hey friends!
This PR adds support for the Nano Matter including:
All of these have been tested and confirmed to function, but feel free to do any additional testing!
ADC support is missing from the main Zephyr repo for the Nano Matter - I'm currently working on adding it. Once it's there I'll also include it here in a separate PR. Besides this the board has a pretty well rounded functionality.
OpenOCD 0.12.0-arduino1-staticwill have to be added to the package.json file - but I assume you keep that separately. This is needed for flasing the Nano Matter.Please, let me know if you have any remarks and I'll fix them as soon as possible!