Skip to content

Libraries dependencies: output error if no valid solution found #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Libraries dependencies: output error if no valid solution found #544

merged 1 commit into from
Jan 30, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 7, 2020

Fix #534

@cmaglie cmaglie self-assigned this Jan 7, 2020
@masci masci added this to the 0.8.0 milestone Jan 14, 2020
rsora
rsora approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmaglie cmaglie merged commit afdf259 into arduino:master Jan 30, 2020
@cmaglie cmaglie deleted the fix-dep-resolver branch January 30, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Library with invalid depends field causes silent failures
3 participants
@cmaglie @rsora @masci