Skip to content

Fix dll build #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FreddieAkeroyd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dll build #563

FreddieAkeroyd wants to merge 1 commit into from
+3 −1

Conversation

@FreddieAkeroyd
Copy link

@FreddieAkeroyd FreddieAkeroyd commented Jan 9, 2026 •
edited
Loading

Set HDF5_STATIC_BUILD correctly for DLL builds. Also fixes the xml2.lib missing issue during link issue.

@FreddieAkeroyd FreddieAkeroyd force-pushed the fix_dll_build branch 3 times, most recently from 958cab2 to 5b5a672 Compare January 9, 2026 00:52
@FreddieAkeroyd FreddieAkeroyd marked this pull request as ready for review January 9, 2026 01:23
@FreddieAkeroyd FreddieAkeroyd mentioned this pull request Jan 9, 2026
Open
@FreddieAkeroyd
Copy link
Author

FreddieAkeroyd commented Jan 9, 2026

Though both ADsupport and ADcore include $(TOP)/configure/CONFIG_SITE.local in their CONFIG_SITE adding to CONFIG_SITE.local did not work but adding to CONFIG_SITE did. Could $(TOP) be not quite right in this case? needs more investigation possibly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FreddieAkeroyd