Check for 7 OK message when waiting for an image to actualy end the acquisition #17
Conversation
…cquisition Sometimes a 15 OK message gets intermixed and prematurely ends the busy record when acquiring images, this can lead to synchronization problems
ArmandoPueyos
left a comment
ArmandoPueyos
left a comment
There was a problem hiding this comment.
This looks like a fix for some intermittent issues I'm having with some ADPilatus. I might try this as soon as I have the opportunity.
@auriocus do you think this is also needed for the multiple image case, that you can find on line 1268?
Cheers,
Armando Pueyos
|
@ArmandoPueyos did you get a chance to test this and what was the result? |
|
@auriocus you never answered the question from @ArmandoPueyos about whether a change is also needed in line 1268 for the multiple image case. |
|
I would think that a similar change is needed for the case of multiple image acquisition. So far I haven't tested it because we only trigger single images. I will run a few tests and update for the multi image case. |
|
@MarkRivers Unfortunately I had no opportunity to test it, as the responsible prefers to have to deal with the intermittent issue and restart the IOC and CamServer than risk for a new version. I'm trying to convince another beamline to give it a try, though. |
|
I've updated the patch to wait correctly also for multiple images. I couldn't trigger the failure mode for multi images though - maybe @ArmandoPueyos can run real test. |
3 participants
With this patch, the driver continues to wait for the acknowledgement that the image acquisition has ended (7 OK message). Before that, the driver assumed the end of acquisition upon receipt of any arbitrary message from the camserver. Sometimes a "15 OK" was stuck / delayed in our system and caused the driver to assume that the image was taken, which caused synchronization problems.