Bypass scaling skip for mono 8 bit images #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the mjpeg codec in use at Diamond, we have been seeing the following crash:
Assertion ((src_linesize) >= 0 ? (src_linesize) : (-(src_linesize))) >= bytewidth failed at src/libavutil/imgutils.c:350for 8 bit mono images when entering the logic block that returns early from formatArray without performing
sws_scale. This crash did not occur before the deprecated API calls were replaced. With some quick benchmarks on my workstation I couldn't see any appreciable change in cpu usage when bypassing this logic, @coretl and I discussed that the simplest solution may be to just scale all images to prevent this crash, though if there are other suggestions I can amend this - for the specific codec I have been testing with the crash can be avoided by setting thestridevariable to 2 or 1.