Split toGeoJSON into 2 functions#4
Open
rjmackay wants to merge 1 commit intoarenevier:masterfrom
ushahidi:master
Open
Split toGeoJSON into 2 functions#4rjmackay wants to merge 1 commit intoarenevier:masterfrom ushahidi:master
rjmackay wants to merge 1 commit intoarenevier:masterfrom
ushahidi:master
Conversation
toGeoJSON() now just run json_encode() on the array output. This means you can get the array to push into another GeoJSON array before encoding, and avoid decoding just to reencode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits toGeoJSON into 1 function to build the array, another to encode.
This means you can get the array to push into another GeoJSON array
before encoding, and avoid decoding just to reencode.