Open
Conversation
arfbtwn
force-pushed
the
feature/track-info
branch
from
23128e2 to
480eb0a
Compare
Resource usage and disposal was quite hard to track, depending on a number of fields and some slightly confusing methods and behaviour. This commit adds an ImageInfo type to the mix as a drop in replacement for the track and image fields handling disposal of the image.
This function call has a lot of positional parameters, we name all but the obvious two coming from the method's signature for readability.
arfbtwn
force-pushed
the
feature/track-info
branch
from
480eb0a to
97e78ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.