Skip to content

Assumptions review/clean-up #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
robfairh wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Assumptions review/clean-up #163

robfairh wants to merge 7 commits into from

Conversation

@robfairh
Copy link
Contributor

@robfairh robfairh commented Feb 26, 2021

Fixes #160

@robfairh robfairh added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:4-In Progress This is actively being worked on by the assignee. Type:Feature New feature or feature request labels Feb 26, 2021
@robfairh robfairh marked this pull request as draft February 26, 2021 12:10
@robfairh
Copy link
Contributor Author

robfairh commented Feb 26, 2021

This PR will remain a draft until all the tables have been reviewed.
I like having a PR to automatically diff master to this new branch.
This way we can also see what other things have been changed by other people editing this file.
Friendly reminder: remember to always pull before doing anything.

@samgdotson
Copy link
Collaborator

samgdotson commented Mar 24, 2021

@robfairh
I think we should get rid of the "imported hydrogen" for the following reasons:

  1. It's not true that the infrastructure for importing hydrogen is free.
  2. The model doesn't use the electrolyzer. If the University uses hydrogen, it should use the hydrogen it creates.

@yardasol yardasol removed their request for review January 18, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samgdotson samgdotson Awaiting requested review from samgdotson

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:4-In Progress This is actively being worked on by the assignee. Type:Feature New feature or feature request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review assumptions for constructing Temoa's model

3 participants

@robfairh @samgdotson