Skip to content

modified the regex #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debelatesfaye merged 1 commit into from
Mar 4, 2025
Merged

modified the regex #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/segmenter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def __init__(self,file_obj):
file = open(self.f_name,'r')

def get_segments(self, input_text):
"Simple segementer spliting texts based on regex."
return re.split("[.!?]",input_text)
"""Simple segmenter splitting texts based on regex while handling decimal points and abbreviations."""
return re.split(r'(?<!\b(?:Dr|Mr|Mrs|Ms|St|Jr|Sr|vs|e\.g|i\.e|etc))(?<!\d)[.!?](?!\d)', input_text)

def is_valid_json(self):
''' check if the file is valid json
Expand Down