Improve Project, add additional features, etc#44
Open
secludedhusky wants to merge 3 commits intoargilo:masterfrom
Open
Improve Project, add additional features, etc#44secludedhusky wants to merge 3 commits intoargilo:masterfrom
secludedhusky wants to merge 3 commits intoargilo:masterfrom
Conversation
Owner
|
Thanks for sharing these improvements! Are you interested in getting some of these changes merged in? If so, I would suggest putting each individual improvement (or closely-related group of improvements) in its own pull request, so that review is manageable. If that's too much work, we could just leave this pull request open and I could pick off whatever changes I find interesting, when I get the chance. |
Contributor
Author
|
Yeah that would be too much work. It'd be preferred if you leave this open and then pick off whatever changes you find interesting. There's a significant amount of changes within my pull request, so it'd take a significant amount of time to split everything up on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a significant amount of stuff that I have implemented into my own personal gr-nrsc5 fork, including the ability to transmit data only channels and specify them within the GNURadio blocks, the ability to get Debug information for LOT files and other transmitter information, improved the logging whenever bitrate is too high on subchannels/data channels, implemented additional Metadata to PSD encoders to allow for all possible fields to be transmitted and sent over TCP, improved LOT file encoding logic and made it significantly quicker, clarified a significant amount of things within the README, among a significant amount of other features. Important Note: This pull request reverts any commits newer than 4 Jan, 2026 so there may need to be some changes made to properly implement newer commits to this fork.