Skip to content

Comments

Improve Project, add additional features, etc#44

Open
secludedhusky wants to merge 3 commits intoargilo:masterfrom
secludedhusky:additionals-v1
Open

Improve Project, add additional features, etc#44
secludedhusky wants to merge 3 commits intoargilo:masterfrom
secludedhusky:additionals-v1

Conversation

@secludedhusky
Copy link
Contributor

This pull request adds a significant amount of stuff that I have implemented into my own personal gr-nrsc5 fork, including the ability to transmit data only channels and specify them within the GNURadio blocks, the ability to get Debug information for LOT files and other transmitter information, improved the logging whenever bitrate is too high on subchannels/data channels, implemented additional Metadata to PSD encoders to allow for all possible fields to be transmitted and sent over TCP, improved LOT file encoding logic and made it significantly quicker, clarified a significant amount of things within the README, among a significant amount of other features. Important Note: This pull request reverts any commits newer than 4 Jan, 2026 so there may need to be some changes made to properly implement newer commits to this fork.

@argilo
Copy link
Owner

argilo commented Feb 10, 2026

Thanks for sharing these improvements!

Are you interested in getting some of these changes merged in? If so, I would suggest putting each individual improvement (or closely-related group of improvements) in its own pull request, so that review is manageable.

If that's too much work, we could just leave this pull request open and I could pick off whatever changes I find interesting, when I get the chance.

@secludedhusky
Copy link
Contributor Author

Yeah that would be too much work. It'd be preferred if you leave this open and then pick off whatever changes you find interesting. There's a significant amount of changes within my pull request, so it'd take a significant amount of time to split everything up on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants