Basic workspace support #1194
Basic workspace support #1194
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
g-r-a-n-t
force-pushed
the
workspace
branch
2 times, most recently
from
fe107eb to
0be0a65
Compare
g-r-a-n-t
force-pushed
the
workspace
branch
5 times, most recently
from
b808912 to
a4d35d7
Compare
g-r-a-n-t
force-pushed
the
workspace
branch
5 times, most recently
from
2b7263e to
109cf36
Compare
|
@g-r-a-n-t Just a quick tip, I see that you assigned us but better to pick us from the "Reviewers" box as that will trigger the proper ask for review process that you probably meant to use. |
cburgdorf
left a comment
cburgdorf
left a comment
There was a problem hiding this comment.
This looks very solid to me. A minor complain (which I haven't actually verified) would be that the approach for updating the TOML file most likely evaporates all existing comments of that TOML file but I don't think that has to be addressed as part of this PR.
Great work!
Yeah, that's a problem. I've been having second thoughts about that feature and might just remove it in a small followup PR. |
4 participants
Adds support for ingot workspaces.