Skip to content

Conversation

@g-r-a-n-t
Copy link
Collaborator

No description provided.

@g-r-a-n-t g-r-a-n-t changed the title Read-only embeded ingot files written to temp for language server navigation Read-only embedded ingot files written to temp for language server navigation Jan 28, 2026
@micahscopes micahscopes self-requested a review January 28, 2026 17:13
@micahscopes
Copy link
Collaborator

Looks quite solid! It'd be really nice to extend this mechanism to support jumping to views of Yul / Sonatina / bytecode in the future. But for now, I love it.

Did you look into any alternative LSP features for displaying a file from the LSP server? In the past I thought I saw something like this, but it being a fairly new and not-yet-supported feature.

Doing a more thorough look now, I'll approve for sure but want to make sure I get a chance to wrap my head around how this fits with other stuff.

@g-r-a-n-t
Copy link
Collaborator Author

Did you look into any alternative LSP features for displaying a file from the LSP server? In the past I thought I saw something like this, but it being a fairly new and not-yet-supported feature.

I looked into it a bit at first and got the impression that that approach would be more complicated due to each editor handling virtual files differently (or not at all). In any case, this behavior is a good fallback and maybe we can add virtual file support one editor at a time.

Copy link
Collaborator

@micahscopes micahscopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Yeah, looks like workspace/getReferenceDocument will come in 3.18. We should target that eventually but not in the near term, I totally agree.

The main followup that could be cool in the nearer term would be to generalize this machinery to be used for displaying Yul/Sonatina IR and maybe even representations of bytecode.

@g-r-a-n-t g-r-a-n-t merged commit 53ff0d0 into argotorg:master Jan 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants