Skip to content

Update python bindings install docs & fix typo in SetAtmosphereHeight binding#45

Open
lhennig wants to merge 14 commits intomasterfrom
lv-python
Open

Update python bindings install docs & fix typo in SetAtmosphereHeight binding#45
lhennig wants to merge 14 commits intomasterfrom
lv-python

Conversation

@lhennig
Copy link
Collaborator

@lhennig lhennig commented Jan 23, 2025

I tried to install the python bindings according to the README.md but it did not work. In the end I checked the Makefile to see what install targets are available, and with make python and make python-install it worked. I updated the docs. I also fixed a typo in the python binding of SetAtmosphereHeight

@lhennig lhennig requested review from arguelles and cnweaver January 23, 2025 12:05
@arguelles arguelles self-assigned this Jan 28, 2025
Copy link
Owner

@arguelles arguelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change in documentation.

@arguelles
Copy link
Owner

I think these changes re good and should be merged.

@lhennig
Copy link
Collaborator Author

lhennig commented Jan 28, 2025

Thanks for the review! I will still wait a bit before merging. The reason is that I have seen that Basia made a pull request around three years ago where she wanted to merge her LV headers and python bindings. I will try to make her changes compatible with the current nuSQuIDS master branch. If this is successful, we ensure that the IceCube and KM3NeT analyses use the same implementation.

@lhennig
Copy link
Collaborator Author

lhennig commented Feb 19, 2025

I tried to make Basia's changes compatible with the latest version of the master branch. Surely this is somehow possible, but I could not figure out how. I would suggest that we merge this branch into master, since this branch compiles and works at runtime. Basia's branch includes more LV physics at this point than mine - for example, her branch has all isotropic LV coefficients included (on-diagonal and off-diagonal), while mine only has $c_{e\mu}$ and $c_{\mu\tau}$. Since I am using this branch for my ongoing analysis, I will update it continuously once I need the other LV coefficients, copy-pasting the physics parts in Basia's branch into my branch.

@lhennig
Copy link
Collaborator Author

lhennig commented Feb 19, 2025

Hi @cnweaver, do you approve the merge request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants