Conversation
arguelles
left a comment
There was a problem hiding this comment.
Simple change in documentation.
|
I think these changes re good and should be merged. |
|
Thanks for the review! I will still wait a bit before merging. The reason is that I have seen that Basia made a pull request around three years ago where she wanted to merge her LV headers and python bindings. I will try to make her changes compatible with the current nuSQuIDS master branch. If this is successful, we ensure that the IceCube and KM3NeT analyses use the same implementation. |
|
I tried to make Basia's changes compatible with the latest version of the master branch. Surely this is somehow possible, but I could not figure out how. I would suggest that we merge this branch into master, since this branch compiles and works at runtime. Basia's branch includes more LV physics at this point than mine - for example, her branch has all isotropic LV coefficients included (on-diagonal and off-diagonal), while mine only has |
|
Hi @cnweaver, do you approve the merge request? |
I tried to install the python bindings according to the README.md but it did not work. In the end I checked the Makefile to see what install targets are available, and with
make pythonandmake python-installit worked. I updated the docs. I also fixed a typo in the python binding ofSetAtmosphereHeight