Security Fix for Resources Downloaded over Insecure Protocol - huntr.dev #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] MITM using "https" links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://huntr.dev/users/Mik317 has fixed the Resources Downloaded over Insecure Protocol vulnerability 🔨. Mik317 has been awarded $25 for fixing the vulnerability through the huntr bug bounty program 💵. Think you could fix a vulnerability like this?
Get involved at https://huntr.dev/
Q | A
Version Affected | ALL
Bug Fix | YES
Original Pull Request | 418sec#1
Vulnerability README | https://github.com/418sec/huntr/blob/master/bounties/npm/selenium-wrapper/1/README.md
User Comments:
Bounty URL: https://www.huntr.dev/bounties/1-npm-selenium-wrapper/
⚙️ Description *
The
selenium wrappermodule contained ainstall.jsscript which downloaded somejarfiles using aninsecure HTTPconnection, which made the client vulnerable againstfile corruptionandarbitrary command execution.💻 Technical Description *
I've simply switched the
linktohttps: the certificate for thehttpsversion of the resource is verified correctly and usinghttpsas library avoidsmitmattacks.🐛 Proof of Concept (PoC) *
No needed
🔥 Proof of Fix (PoF) *
No needed
👍 User Acceptance Testing (UAT)
Downloaded correctly the file and no error thrown